-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
Rollup of 7 pull requests #149909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 7 pull requests #149909
Conversation
they are much readable this way imo
This is a general advice, and so shouldn't be repeated
This makes the labels redundant.
Add a new lint that detects the use of decimal literals as bit masks in bitwise operations. Using decimal literals for bit masks can obscure the intended bit pattern and reduce code readability. This lint encourages the use of binary (`0b...`) or hexadecimal (`0x...`) notation to make bit patterns explicit and easier to understand at a glance. Example: ```rust let masked = x & 14; // Bad: decimal literal as bit mask let masked = x & 0b1110; // Good: bit pattern is explicit ``` changelog: [`decimal_bitwise_operands`]: new lint Fixes rust-lang/rust-clippy#1775
Related to https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast (and very much modelled off of its implementation). This lint is motivated by cleaning up the output of [c2rust](https://c2rust.com/), which contains many `.offset` calls with by literal. The lint also nicely handles offsets by zero, which are unnecessary. I'm aware that the feature freeze is still in place, but this was top-of-mind now. I'll patiently wait until the freeze is lifted. changelog: [`ptr_offset_by_literal`]: add `ptr_offset_by_literal` lint
…15101) Closes rust-lang/rust-clippy#15099 The compiler will generate a special `main` function for the tests, which caused this FP. changelog: [`large_stack_frames`] fix FP on compiler generated targets
Now the program checks for transmutting from a struct containing a
single raw pointer to a reference.
```Rust
struct Foo(*const i32);
fn foo(foo: Foo) -> &i32 {
unsafe { transmute(foo) }
}
```
changelog: [`transmute_ptr_to_ref`]: now checks for a pointer wrapped in
a struct
Now the program checks for transmutting from a struct containing a single raw pointer to a raw pointer. changelog: [`transmute_ptr_to_ptr`]: now checks for a pointer wrapped in a struct
Before this PR: <img width="722" height="306" alt="Screenshot From 2025-11-28 13-04-55" src="https://github.com/user-attachments/assets/8c2d1eb2-6030-43d1-984a-174988c73e76" /> With this PR: <img width="722" height="306" alt="Screenshot From 2025-11-28 13-05-01" src="https://github.com/user-attachments/assets/ae8a344f-b876-44b3-9ddc-aaeebc0dccd4" /> r? @Alexendoo changelog: Fix display of dropdown menu "buttons"
Revival of rust-lang/rust-clippy#13331 Part of rust-lang/rust-clippy#12894 changelog: [`manual_ilog2`]: new lint
bootstrap: add rustc-dev install target I'm entirely new to bootstrap but there seemed to be no easy way to construct a sysroot with tools and librustc_driver.so. `./x install` is the command for that but as far as I can tell it doesn't include the rustc-dev files. This is my attempt at adding that. `./x install rustc-dev` now does what you expect (at least on my machine™). If I'm understanding correctly this also means that `./x install` will now include rustc-dev files if `build.tools` contains `"rustc-dev"`.
…ram, r=jdonszelmann Cleanup in the attribute parsers * Removes a bunch of unused lifetimes in the attribute parsers * Creates two variants of `PathParser`, because we statically know which variant we're in r? ```````@jdonszelmann```````
…elmann
Remove uses of `cfg({any()/all()})`
~~This implements the followup warning suggested in rust-lang/rfcs#3695
~~Lint against an empty `cfg(any/all)`, suggest the boolean literal equivalents.~~
rust-lang#149791 (comment)
Tracking issue: rust-lang#131204
Suggest `cfg(false)` instead of `cfg(FALSE)` Split from rust-lang#149791 cc ```````@Urgau```````
add regression test for `proc_macro` error subdiagnostics The previous ICE was already fixed by rust-lang#148188, but no test was added at that time. Closes rust-lang#145305.
…matthiaskrgr Clippy subtree update r? ``````@Manishearth`````` Cargo.lock update due to Clippy version bump.
Add myself(makai410) to the review rotation Per the rust-lang/team#2177 .
|
@bors r+ rollup=never p=5 |
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR:
previous master: 2a3a62d26e In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 2a3a62d (parent) -> 3391c01 (this PR) Test differencesShow 9 test diffsStage 1
Stage 2
Additionally, 3 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 3391c0133661be933c3ef24edf1867d71b9f206b --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
Successful merges:
cfg({any()/all()})#149791 (Remove uses ofcfg({any()/all()}))cfg(false)instead ofcfg(FALSE)#149792 (Suggestcfg(false)instead ofcfg(FALSE))proc_macroerror subdiagnostics #149883 (add regression test forproc_macroerror subdiagnostics)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup